Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular email provider on disposable email list #34

Closed
mfly opened this issue Oct 8, 2015 · 3 comments
Closed

Regular email provider on disposable email list #34

mfly opened this issue Oct 8, 2015 · 3 comments

Comments

@mfly
Copy link

mfly commented Oct 8, 2015

The "poczta.onet.pl" domain belongs to e-mail service provided by the biggest Polish web portal - onet.pl. It shouldn't be blacklisted.

It was included in this commit:

As you can see, the problem has quite impressive roots. I propose removing the domain from the list, implementing domain whitelist to quickly patch future mistakes, and also paying more attention to validation before blacklisting a domain.

Possible workarounds:

  • downgrade gem to 1.1.9
  • disable disposable email validation
@mfly mfly mentioned this issue Oct 8, 2015
@micke micke closed this as completed in e640689 Oct 9, 2015
@micke
Copy link
Owner

micke commented Oct 9, 2015

Thanks for bringing this up and i'm sorry that poczta.onet.pl sneaked through.
I'm usually always checking all the additions to the list so that this wouldn't happen but the PR in question included over 500 new providers and i didn't have time to check them all.

I've pushed v1.1.11 to rubygems which fixes this issue.

@mpokrywka
Copy link

onet.pl & poczta.onet.pl are again on the list of disposable mails, please those domains from disposable_emails.yml

@micke
Copy link
Owner

micke commented Nov 30, 2017

@mpokrywka Thanks, i've removed them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants