Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching of domain dns/mx check #179

Closed
la-ruby opened this issue Jun 13, 2021 · 2 comments · Fixed by #256
Closed

Caching of domain dns/mx check #179

la-ruby opened this issue Jun 13, 2021 · 2 comments · Fixed by #256

Comments

@la-ruby
Copy link

la-ruby commented Jun 13, 2021

ValidEmail2::Address.new("[email protected]").valid_mx?  => false

the fact that ymail.con is not a valid domain, can the gem cache that fact?
during bulk checking of 1000 email addresses, that would avoid the need to make 1000 network requests.

@micke
Copy link
Owner

micke commented Jun 26, 2021

Great idea! A PR is most welcome!

@ianbayne
Copy link
Contributor

ianbayne commented Oct 5, 2024

Any thoughts on desired implementation for this, @micke? For example, a simple class-level cache using a class variable? Or something thread-safe like concurrent-ruby or Rails.cache (through requiring activesupport I guess)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants