Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mi/collect! without args doesn't work properly #834

Closed
bartkl opened this issue Feb 1, 2023 · 0 comments · Fixed by #835
Closed

mi/collect! without args doesn't work properly #834

bartkl opened this issue Feb 1, 2023 · 0 comments · Fixed by #835

Comments

@bartkl
Copy link

bartkl commented Feb 1, 2023

As discussed on Slack, this code provided by @ikitommi works fine:

(ns demo)

(defn plus
  "adds two numbers together"
  {:malli/schema [:=> [:cat :int :int] :int]}
  [z y]
  (+ z y))

(require '[malli.instrument])
(malli.instrument/collect! {:ns 'demo})
;#{{:clj {demo {plus {:schema [:=> [:cat :int :int] :int]
;                     :ns demo, :name plus}}}}}

But (malli.instrument/collect!) without arguments does not. It gives something like:

Syntax error (ClassNotFoundException) compiling at ...
demo

Per request I created this issue.

ikitommi: Ugh, that doesn't look right. Not using the 0-arity, it's clearly broken.
ikitommi: Issue welcome, should be easy to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant