Clarify and maybe change unparse behavior
#1123
Labels
Comments
|
result of parse is actually a |
|
To clarify, here's how to get the original example to work: (malli.core/unparse int-or-string (malli.impl.util/-tagged :int 1)) ; => 1
;; OR
(malli.core/unparse int-or-string (clojure.lang.MapEntry. :int 1)) ; => 1I agree that this is unwieldy. It would be easy to changed |
|
After thinking about it for a bit, I think this is a safe change. I've prepared a PR (#1140). |
opqdonut
added a commit
that referenced
this issue
Dec 16, 2024
Using a MapEntry was confusing users, because it printed like a vector, but you couldn't give a vector to unparse. The current method of using MapEntry was broken for weird schemas: ``` (def schema [:or [:tuple :string :keyword] [:orn ["any" :keyword]]]) (->> (m/parse schema :any) (m/unparse schema)) ; => ["any" :any] ; should've been :any ``` Changes the parse behaviour for (at least) :orn, :altn and :multi Some place (like the entry parsers) used miu/-tagged to generate MapEntry values. These use sites now use the new miu/-entry. This keeps the surface area of this change a lot smaller since we don't need to touch all the map entry logic. fixes #1123 replaces #1140
|
A new solution that uses a custom record for parse output in #1150 |
opqdonut
added a commit
that referenced
this issue
Dec 16, 2024
Using a MapEntry was confusing users, because it printed like a vector, but you couldn't give a vector to unparse. The current method of using MapEntry was broken for weird schemas: ``` (def schema [:or [:tuple :string :keyword] [:orn ["any" :keyword]]]) (->> (m/parse schema :any) (m/unparse schema)) ; => ["any" :any] ; should've been :any ``` Changes the parse behaviour for (at least) :orn, :altn and :multi Some place (like the entry parsers) used miu/-tagged to generate MapEntry values. These use sites now use the new miu/-entry. This keeps the surface area of this change a lot smaller since we don't need to touch all the map entry logic. fixes #1123 replaces #1140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As posted on slack, data equal to the result of
malli.core/parsecannot be unparsed.I have some data in my schema's parsed format, which was not produced by
parse, but which I would like to unparse. It appears that's not currently possible.The text was updated successfully, but these errors were encountered: