Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Blending fails with 0 weight for passed data #2054

Open
SamGriffithsMO opened this issue Nov 25, 2024 · 0 comments
Open

BUG: Blending fails with 0 weight for passed data #2054

SamGriffithsMO opened this issue Nov 25, 2024 · 0 comments
Labels

Comments

@SamGriffithsMO
Copy link
Contributor

SamGriffithsMO commented Nov 25, 2024

When calling improver weighted-blending via the CLI, it is possible to pass multiple cubes that all have weights of 0 (as the graph has no knowledge of the blending weights). e.g. tempmax12h, for a 24 hour leadtime being passed engluk and ecukx only.

Currently this results in blending.weights.WeightsUtilities raising ValueError("Sum of weights must be > 0.0"). It is desirable for this to be a warning so that suites can continue to cycle.

Acceptance criteria:

  1. No change when presented with a full data set
  2. If there is no weight to any input, raise a warning and return None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant