-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package.__init__() got an unexpected keyword argument 'autolib' #13826
Labels
Comments
@xclaesse I think my initial easy approach of splatting the dict is going to be problematic, and we probably want to be explicit, plus warn when there are keys the version of Meson doesn't understand. |
dcbaker
added a commit
to dcbaker/meson
that referenced
this issue
Oct 27, 2024
This adds support for parsing the new `autolib` member (rust-lang/cargo#14591). This is a quick and easy fix, suitable for backport. A larger more involved fix will be to stop splatting out the cargo dictionaries, and instead pass the fields we know about 1 by 1, and warning the user if we come across unknown fields. Fixes: mesonbuild#13826
dcbaker
added a commit
to dcbaker/meson
that referenced
this issue
Oct 27, 2024
This adds support for parsing the new `autolib` member (rust-lang/cargo#14591). This is a quick and easy fix, suitable for backport. A larger more involved fix will be to stop splatting out the cargo dictionaries, and instead pass the fields we know about 1 by 1, and warning the user if we come across unknown fields. Fixes: mesonbuild#13826
We could still single-source the fields themselves using e.g. |
dcbaker
added a commit
to dcbaker/meson
that referenced
this issue
Oct 28, 2024
Cargo sometimes adds new keys and Meson needs to gracefully handle those. Currently, an unknown key will trigger an uncaught Python exception, which is pretty much the worse case. With this change Meson will instead issue a warning much like the one for unknown cpu architectures. See mesonbuild#13826 for the motivation for this change
dcbaker
added a commit
to dcbaker/meson
that referenced
this issue
Oct 28, 2024
Cargo sometimes adds new keys and Meson needs to gracefully handle those. Currently, an unknown key will trigger an uncaught Python exception, which is pretty much the worse case. With this change Meson will instead issue a warning much like the one for unknown cpu architectures. See mesonbuild#13826 for the motivation for this change
dcbaker
added a commit
to dcbaker/meson
that referenced
this issue
Nov 1, 2024
Cargo sometimes adds new keys and Meson needs to gracefully handle those. Currently, an unknown key will trigger an uncaught Python exception, which is pretty much the worse case. With this change Meson will instead issue a warning much like the one for unknown cpu architectures. See mesonbuild#13826 for the motivation for this change
dcbaker
added a commit
to dcbaker/meson
that referenced
this issue
Nov 1, 2024
Cargo sometimes adds new keys and Meson needs to gracefully handle those. Currently, an unknown key will trigger an uncaught Python exception, which is pretty much the worse case. With this change Meson will instead issue a warning much like the one for unknown cpu architectures. See mesonbuild#13826 for the motivation for this change
dcbaker
added a commit
to dcbaker/meson
that referenced
this issue
Nov 1, 2024
Cargo sometimes adds new keys and Meson needs to gracefully handle those. Currently, an unknown key will trigger an uncaught Python exception, which is pretty much the worse case. With this change Meson will instead issue a warning much like the one for unknown cpu architectures. See mesonbuild#13826 for the motivation for this change
dcbaker
added a commit
to dcbaker/meson
that referenced
this issue
Nov 1, 2024
Cargo sometimes adds new keys and Meson needs to gracefully handle those. Currently, an unknown key will trigger an uncaught Python exception, which is pretty much the worse case. With this change Meson will instead issue a warning much like the one for unknown cpu architectures. See mesonbuild#13826 for the motivation for this change
eli-schwartz
pushed a commit
that referenced
this issue
Nov 5, 2024
Cargo sometimes adds new keys and Meson needs to gracefully handle those. Currently, an unknown key will trigger an uncaught Python exception, which is pretty much the worse case. With this change Meson will instead issue a warning much like the one for unknown cpu architectures. See #13826 for the motivation for this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
New versions of Rust's Cargo package manager have started publishing an
autolib
entry in Cargo.toml.autolib
rust-lang/cargo#14591autolib = false
in https://docs.rs/crate/proc-macro2/1.0.87/source/Cargo.tomlAll packages published to crates.io by a recent version of Cargo contain this entry.
To Reproduce
This is the relevant line:
meson/mesonbuild/cargo/interpreter.py
Line 358 in db82c2d
Expected behavior
Presence of
autolib = false
within the Cargo.toml of amethod = cargo
wrap-file does not cause a type error in Meson's cargo interpreter.The path determined by
[lib] path = "..."
in the Cargo.toml is treated as the root of the crate's library.system parameters
meson --version
ninja --version
if it's a Ninja buildThe text was updated successfully, but these errors were encountered: