Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add timeout param to scrape and crawl #65

Closed
wants to merge 9 commits into from

Conversation

ezhil56x
Copy link

/claim #59

@rafaelsideguide
Copy link
Collaborator

@ezhil56x awesome job! Could you add some e2e tests?

@ezhil56x
Copy link
Author

ezhil56x commented Apr 25, 2024

@rafaelsideguide
Should we have a default timeout or is it not required?

@ezhil56x
Copy link
Author

@rafaelsideguide
Can I get a review once?

@rafaelsideguide
Copy link
Collaborator

@ezhil56x
for /scrape the default should be 20 seconds
for /crawl the default should be this.limit x 20 seconds

@ezhil56x
Copy link
Author

@rafaelsideguide
Done!

@rafaelsideguide
Copy link
Collaborator

@ezhil56x crawl is not working properly. I added a test on e2e_withAuth with how it's supposed to work.

@ezhil56x
Copy link
Author

@rafaelsideguide
Updated my PR

@rafaelsideguide
Copy link
Collaborator

The v0/crawl test does not pass. The timeout function runs, but the job is still running, so it crawls the pages and returns a success response. This should not happen.

Captura de Tela 2024-04-29 às 09 18 04

@rafaelsideguide rafaelsideguide self-assigned this Apr 30, 2024
Need to find a way to return 408 to timed out requests
job is not being moved to failed jobs...
@nickscamara
Copy link
Member

@rafaelsideguide we should also support partial docs on the webhook, just got a customer request for that!

@nickscamara
Copy link
Member

/tip $10

Copy link

algora-pbc bot commented May 13, 2024

🎉🎈 @ezhil56x has been awarded $10! 🎈🎊

@nickscamara
Copy link
Member

@ezhil56x thanks for the initial contribution, unfortunately we are closing this for now as we will need some architectural changes to be able to do timeout in the crawl reliably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants