-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add timeout param to scrape and crawl #65
Conversation
@ezhil56x awesome job! Could you add some e2e tests? |
@rafaelsideguide |
@rafaelsideguide |
@ezhil56x |
@rafaelsideguide |
- Crawl is not working
@ezhil56x crawl is not working properly. I added a test on |
@rafaelsideguide |
Need to find a way to return 408 to timed out requests
job is not being moved to failed jobs...
@rafaelsideguide we should also support partial docs on the webhook, just got a customer request for that! |
/tip $10 |
🎉🎈 @ezhil56x has been awarded $10! 🎈🎊 |
@ezhil56x thanks for the initial contribution, unfortunately we are closing this for now as we will need some architectural changes to be able to do timeout in the crawl reliably. |
/claim #59