Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] format: ["links"] doesn't respect excludeTags #701

Open
mogery opened this issue Sep 24, 2024 · 6 comments · May be fixed by #828
Open

[Bug] format: ["links"] doesn't respect excludeTags #701

mogery opened this issue Sep 24, 2024 · 6 comments · May be fixed by #828
Assignees
@mogery
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mogery
Copy link
Member

mogery commented Sep 24, 2024

Discord thread

const INPUT_URL = "https://www.jndla.com/cases/class-action-administration"

const response = await app.scrapeUrl(INPUT_URL, {
  formats: ["links"],
  excludeTags: ["a"],
})

console.log(response.links)
// this still has links, even though we excluded the <a> tags
@mogery mogery added the bug Something isn't working label Sep 24, 2024
@mogery mogery self-assigned this Sep 24, 2024
@baraich

This comment was marked as spam.

Sign in to view
@mogery

This comment was marked as off-topic.

Sign in to view
@baraich

This comment was marked as spam.

Sign in to view
@mogery

This comment was marked as off-topic.

Sign in to view
@baraich

This comment was marked as spam.

Sign in to view
@nickscamara nickscamara added the good first issue Good for newcomers label Oct 23, 2024
@txrp0x9
Copy link

txrp0x9 commented Oct 27, 2024 •
edited
Loading

Seems like a small change, links seem to extracted on the raw HTML before applying excludeTags

Unless this was behaviour was intended by some other design I missed :)

@txrp0x9 txrp0x9 linked a pull request Oct 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mogery mogery

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Links are now extracted after applying excludeTags txrp0x9/firecrawl
4 participants
@nickscamara @txrp0x9 @mogery @baraich