Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Change to return type of utc_now from pendulum.DateTime to datetime.datetime #2453

Merged
merged 1 commit into from
May 27, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented May 27, 2024

Copy link

codspeed-hq bot commented May 27, 2024

CodSpeed Performance Report

Merging #2453 will not alter performance

Comparing edgarrmondragon/refactor/utc_now-return-type (d10fb43) with main (731fc35)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.18%. Comparing base (731fc35) to head (d10fb43).
Report is 135 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2453   +/-   ##
=======================================
  Coverage   89.18%   89.18%           
=======================================
  Files          54       54           
  Lines        4790     4791    +1     
  Branches      937      937           
=======================================
+ Hits         4272     4273    +1     
  Misses        361      361           
  Partials      157      157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review May 27, 2024 20:33
@edgarrmondragon edgarrmondragon merged commit abc43eb into main May 27, 2024
35 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/refactor/utc_now-return-type branch May 27, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant