-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'users of melange widget' to front page #196
base: master
Are you sure you want to change the base?
Conversation
export const users = [ | ||
{ | ||
name: "Ahrefs", | ||
image: "ahrefs.svg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the newest ahrefs logo from https://ahrefs.com/logo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in e51bf5e
docs/.vitepress/theme/index.js
Outdated
@@ -1,10 +1,11 @@ | |||
// You can directly import Vue files in the theme entry | |||
// VitePress is pre-configured with @vitejs/plugin-vue. | |||
import Layout from './Layout.vue' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, but why do we use vue for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Afaik, we have to use Vue components in VitePress if we want to use custom components. For example, @jchavarri implemented syntax switching by making a Vue component: https://github.com/melange-re/melange-re.github.io/blob/master/docs/.vitepress/theme/Switch.vue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. There's no way around that, at least that I know of. Unless we move away from Vitepress to something React based.
docs/.vitepress/theme/Users.vue
Outdated
{ | ||
name: "Atvero", | ||
image: "atvero.svg", | ||
infoLink: "https://atvero.com", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This site doesn't open.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it should be updated to https://www.cmap.io/ instead. Will contact the guy from Reason discord who works at CMap (which I assume acquired Atvero).
Update: Pushed tentative change that replaces Atvero with CMap in 27a1c5f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, just to confirm we did migrate the product to Melange, and the link you have is the correct one. Thanks for updating!
Addresses #74
This is basically a clone of the 'Users of Reason' section from https://reasonml.github.io/. I copied the styles from the original page, but also tried to adjust them to match the styles for the theme of this site. I didn't copy all the logos over because I don't believe all of the companies on the Reason homepage have all switched to Melange (and some are not obviously still in business).
I think we'd want to add more company logos before we merge this.