Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'users of melange widget' to front page #196

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

feihong
Copy link
Collaborator

@feihong feihong commented Oct 11, 2024

Addresses #74

This is basically a clone of the 'Users of Reason' section from https://reasonml.github.io/. I copied the styles from the original page, but also tried to adjust them to match the styles for the theme of this site. I didn't copy all the logos over because I don't believe all of the companies on the Reason homepage have all switched to Melange (and some are not obviously still in business).

I think we'd want to add more company logos before we merge this.

@feihong feihong marked this pull request as ready for review October 11, 2024 19:31
@feihong feihong requested review from jchavarri and davesnx October 11, 2024 19:32
export const users = [
{
name: "Ahrefs",
image: "ahrefs.svg",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the newest ahrefs logo from https://ahrefs.com/logo

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in e51bf5e

@@ -1,10 +1,11 @@
// You can directly import Vue files in the theme entry
// VitePress is pre-configured with @vitejs/plugin-vue.
import Layout from './Layout.vue'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, but why do we use vue for this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaik, we have to use Vue components in VitePress if we want to use custom components. For example, @jchavarri implemented syntax switching by making a Vue component: https://github.com/melange-re/melange-re.github.io/blob/master/docs/.vitepress/theme/Switch.vue

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. There's no way around that, at least that I know of. Unless we move away from Vitepress to something React based.

{
name: "Atvero",
image: "atvero.svg",
infoLink: "https://atvero.com",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This site doesn't open.

Copy link
Collaborator Author

@feihong feihong Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it should be updated to https://www.cmap.io/ instead. Will contact the guy from Reason discord who works at CMap (which I assume acquired Atvero).

Update: Pushed tentative change that replaces Atvero with CMap in 27a1c5f

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, just to confirm we did migrate the product to Melange, and the link you have is the correct one. Thanks for updating!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants