Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grunt dev and grunt e2e fight each other, and nobody wins #2688

Closed
SCdF opened this issue Aug 31, 2016 · 7 comments
Closed

grunt dev and grunt e2e fight each other, and nobody wins #2688

SCdF opened this issue Aug 31, 2016 · 7 comments
Labels
Type: Bug Fix something that isn't working as intended Type: Technical issue Improve something that users won't notice
Milestone
September 5th - S...

Comments

@SCdF
Copy link
Contributor

SCdF commented Aug 31, 2016

If you have grunt dev sitting the background and try to run grunt e2e they break each other. It is probably the excessive list of startup hullabaloo / foofaraw causing dev to fire, which in turn causes the state on disk to not be compatible with deployment.
@SCdF SCdF added Type: Bug Fix something that isn't working as intended Type: Technical issue Improve something that users won't notice labels Aug 31, 2016
@SCdF SCdF added this to the September 5th - September 19th milestone Sep 7, 2016
@SCdF SCdF self-assigned this Sep 7, 2016
@SCdF
Copy link
Contributor Author

SCdF commented Sep 7, 2016

Grunt is catching api_working somehow, which is causing deploy to fire.

@SCdF
Copy link
Contributor Author

SCdF commented Sep 7, 2016

So this is weird, watch catches any new directory in the root directory even if you're not watching for them. It is correctly ignoring new files in the root directory.

@SCdF
Copy link
Contributor Author

SCdF commented Sep 7, 2016

So I think this is either a grunt-contrib-watch bug, or we don't understand the syntax that we should be using in the files property. I've created a test repo and filed a bug with grunt-contrib-watch: gruntjs/grunt-contrib-watch#519

@SCdF SCdF added the Status: Blocked Unable to progress this. label Sep 7, 2016
@SCdF
Copy link
Contributor Author

SCdF commented Sep 7, 2016

Blocked on a response from the linked ticket.

@SCdF
Copy link
Contributor Author

SCdF commented Sep 8, 2016

So I dug a little further, this is a problem with Gaze, the library that watch uses: shama/gaze#204

SCdF added a commit that referenced this issue Sep 8, 2016
@SCdF
Patched grunt-contrib-watch #2688
9ef618d 
Moves us to a patched version of grunt-contrib-watch which ignores
fires from Gaze (the lib around fsevents used to detect fs changes)
which don't actually match the files you specify.

This means that when kanso creates directores in root grunt dev no
longer fires incorrectly, breaking both grunt dev and kanso.
@SCdF
Copy link
Contributor Author

SCdF commented Sep 8, 2016

grunt-contrib-watch patch commit is here: SCdF/grunt-contrib-watch@896dba3

@SCdF SCdF assigned garethbowen and unassigned SCdF Sep 8, 2016
@SCdF
Copy link
Contributor Author

SCdF commented Sep 8, 2016

@garethbowen please check out the change to our package.json as well as the linked patch to grunt-contrib-watch.

I tried writing a test for watch, but their framework for testing doesn't lend itself well to testing that something doesn't occur, so I haven't got a good solid test for now.

@SCdF SCdF removed the Status: Blocked Unable to progress this. label Sep 8, 2016
@garethbowen garethbowen removed their assignment Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Fix something that isn't working as intended Type: Technical issue Improve something that users won't notice
Projects
None yet
Milestone
September 5th - September 19th
Development

No branches or pull requests
2 participants
@SCdF @garethbowen