French IBAN does not always return the right BIC

[cedk]

There are many banks with the same bank_code but different BIC. So when getting the BIC from an IBAN schwifty takes the last bank loaded with the bank_code. I think it will be better in case of ambiguity that no BIC is returned.

[n49o7]

In the file bank_registry/manual_fr.json, we see that there are often multiple branches for the same bank. For instance PSSTFRPPLYO, PSSTFRPPPAR, PSSTFRPPTOU and so on, or NORDFRPP and NORDFRPPXXX). In this case, the branch code should help distinguish.

[Natim]

Hello @cedk actually, you have multiple utilities to handle this case.
By default Schwifty will give you the generic BIC (ending with XXX or with the XXX stripped) so that the BIC provided will allow the routing anyway.
You can also get the list of related BIC to let your customer pick the one they want.

• BIC.candidates_from_bank_code: https://github.com/mdomke/schwifty/blob/main/schwifty/bic.py#L91C9-L91C35
• BIC.from_bank_code: https://github.com/mdomke/schwifty/blob/main/schwifty/bic.py#L183C9-L183C23