-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jump to section => Table of contents #1371
Comments
I don't understand where this will appear. Is it possible to show the rendered before and after of this proposed change? |
Actually I don't know how to test like modify in inspector since I'm from a smartphone (this Is because my PRs has 99 commits) 🤷🏻♂️ Ideally a PR should be deployed... But i don't know how to do It and if it costs some Cloud cost... Another issue Is that It says Jump to section but often It jumps to heading... |
You can try to checkout t'ha branch (of my fork) of this PR And start the project locally reading the readme. I don't know if It Is updated now 🤔 |
Not need thanks @mattiapontonio - your screenshot makes sense. So the proposed change is the text - ie I have a very slight preference for the current "Jump to section" because the word "section" implies to me a jump within the same document. If this said "table of contents", then perhaps I might consider this a table of site articles. Others might disagree. @chrisdavidmills |
PS Sorry I was slow to respond. I personally "like" the term "Table of contents" more - it was hard to find a good way to explain why objectively the current version is probably better. |
Ah You want a section and not a dropdown. Make sense. P1 -> make a section This solves a lot of z-index / issues... Can We change this in content? We should do the table of contents manually 👷👷♀️👷♂️🙄🙄🙈 Even that make sense. |
@mattiapontonio Just to be clear, I was only commenting on the text "Jump to section" vs "Table of contents". Please don't assume I'm commenting on anything else from the screenshot :-) That said, I do think it is important for the list of page headings (i.e. the page toc) to be readily accessible - in this case a dropdown that is open by default when you load a page. This sort of thing is IMO best managed by a product manager - who would define how they want all the page elements to behave. Upshot "I'm am full of opinions, but I don't want to waste your time working on things without some sort of consensus from the whole content team". |
@hamishwillee How do you make the list so vertical without dots? |
@mattiapontonio I cheated because my image was just to confirm your intent (screenshot of this page then changed the text, took a second screenshot and combined). But if I had to do this properly - something like https://www.w3schools.com/html/tryit.asp?filename=tryhtml_lists_unordered_none |
@hamishwillee ok thanks. |
Ah, those classic bikeshed moments ;-) I don't really care that much, as I think any improvement make on this would be prety minor. But here's my 2pence:
Which leads me to think is there third option, maybe "Article contents"? I dunno, doesn't feel great either. As I said, I don't think this is worth spending too much time on. |
Should be fun to style a little light border on sections... 🙂 Just to see how it looks. |
Article contents would work for me too. |
Yup ;-) |
Reopen. |
What issue (in URL)? |
I like this bikeshed better than "Jump to section" (literal but a bit unusual and thus unnecessarily brain-tickling) and "Table of contents" (not something you'd expect to see in a side bar). Another option would be to pick "On this page" |
So removing It and leave the sidebar only on the right? I'm not sure. |
I will close this. |
Reword the heading from "Jump to section" to "Table of contents"
The text was updated successfully, but these errors were encountered: