Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt true semantic versioning #150

Closed
terrillmoore opened this issue Apr 3, 2021 · 0 comments
Closed

Adopt true semantic versioning #150

terrillmoore opened this issue Apr 3, 2021 · 0 comments
Assignees

Comments

@terrillmoore
Copy link
Member

terrillmoore commented Apr 3, 2021

The version numbers in our BSPs are semi-semver 2.0 compliant -- but the fourth field local is compared numerically rather than semantically. It's supposed to be a pre-release, and 0 is supposed to be less than any other.

The simple way to fix this is to retain the numerical values, but introduce comparison macros that knows the rules.

Luckily existing uses will not be affected (if you think through the existing uses, which numerically are comparing to older versions that differ by more than the local/prerelease field. So this doesn't drive a major version increment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant