-
Notifications
You must be signed in to change notification settings - Fork 541
Ensure tags in the autocomplete input are not in the suggestion-list and visa versa #224
Comments
After doing some more testing it looks like elements are removed from the suggestion-list under certain circumstances but not others. Tags that have a space in them, e.g. 'Paulette Cross', are never removed from the suggestion-list while tags with no spaces, e.g. 'SaulWade' are.removed. |
Got it. Looks like the default for replace-spaces-with-dashes is true which will cause this if the data in the suggestion-list has spaces in it. |
I assume this has been worked out. Can this issue be closed? |
Should the default behaviour not rather be not to replace-spaces-with-dashes? This would most likely be less surprising to new users. Also, if replace-spaces-with-dashes is on it breaks your internal diff algorithm leading to the issue reported here. |
That's arguable. If you use ngTagsInput to simply collect tags - which was the problem this project was trying to solve back when it was started -, then you will probably want the spaces to be replaced with dashes.
I agree that's an issue. I'll add it to the backlog. |
Done. #232 |
Closing due to inactivity. |
It would be more intuitive if elements are removed from the suggestion-list when they are chosen and successfully added to the autocomplete input. The reverse, removing a tag from the autocomplete inout should add it back to the suggestion-list.
This really helps avoiding you having to traverse elements in the suggestion-list that you've already added to the autocomplete input, and cannot add in again in any case.
The text was updated successfully, but these errors were encountered: