Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to choose reference over pointer #106

Closed
hamishwillee opened this issue Mar 13, 2018 · 1 comment
Closed

Update docs to choose reference over pointer #106

hamishwillee opened this issue Mar 13, 2018 · 1 comment
Assignees

Comments

@hamishwillee
Copy link
Collaborator

hamishwillee commented Mar 13, 2018

As discussed here: mavlink/MAVSDK#314. Depends on this PR: mavlink/MAVSDK#316

From a docs perspective this pretty much involves doing a global search->replace of "&device" to device where the device is used:

auto telemetry = std::make_shared<Telemetry>(&device);

TO

auto telemetry = std::make_shared<Telemetry>(device);

BUT cannot do a pure replace, because we still create the reference in the same way:

Device &device = dc.device();

Will also need to rebuild API reference.

@hamishwillee
Copy link
Collaborator Author

Will be fixed by #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant