Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Namespace (and possibly spec) HS_DISABLED error code #9237

Open
Half-Shot opened this issue Jan 27, 2021 · 4 comments
Open

Namespace (and possibly spec) HS_DISABLED error code #9237

Half-Shot opened this issue Jan 27, 2021 · 4 comments
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@Half-Shot
Copy link
Collaborator

As per matrix-org/matrix-react-sdk#5576 (comment)

I'm mindful to namespace it now, as I don't think we make any assurances that random unspecced strings must remain the same.

@Half-Shot
Copy link
Collaborator Author

Turns out that the error response

class ResourceLimitError(SynapseError):
is also not specified.

@anoadragon453 anoadragon453 changed the title hs_disabled is a unspecced resource limit error type, and should be namespaced Namespace (and possibly spec) HS_DISABLED and M_RESOURCE_LIMIT_EXCEEDED error codes Feb 1, 2021
@anoadragon453
Copy link
Member

This was added back in v1.7.2: #6173

Indeed, it should probably be namespaced or specced, just as monthly_active_user currently is. HS_DISABLED sounds rather homeserver agnostic, so I'd probably advocate for the latter.

@anoadragon453 anoadragon453 added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Feb 1, 2021
@anoadragon453 anoadragon453 changed the title Namespace (and possibly spec) HS_DISABLED and M_RESOURCE_LIMIT_EXCEEDED error codes Namespace (and possibly spec) HS_DISABLED error code Feb 1, 2021
@anoadragon453
Copy link
Member

Err, wait M_RESOURCE_LIMIT_EXCEEDED at least is specced: https://matrix.org/docs/spec/client_server/r0.6.1#api-standards

@Half-Shot
Copy link
Collaborator Author

The string M_RESOURCE_LIMIT_EXCEEDED, but the spec writer neglected to include the additional keys in the error body.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

No branches or pull requests

2 participants