Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Convert streams to async. #8014

Merged
merged 3 commits into from
Aug 4, 2020
Merged

Convert streams to async. #8014

merged 3 commits into from
Aug 4, 2020

Conversation

clokep
Copy link
Member

@clokep clokep commented Jul 31, 2020

This is a tiny PR, but it was standalone so I figure it was worth putting up.

Notable that most of these functions weren't returning a Deferred anymore, it seems only the RoomEventSource.get_current_key() does. The rest just return integers.

@clokep clokep force-pushed the clokep/async-streams branch from e09dd63 to 652248a Compare July 31, 2020 19:20
@clokep clokep requested a review from a team July 31, 2020 20:23
@anoadragon453
Copy link
Member

anoadragon453 commented Jul 31, 2020 •
edited
Loading

Notable that most of these functions weren't returning a Deferred anymore, it seems only the RoomEventSource.get_current_key() does. The rest just return integers.

This seems like it could lead to confusion. Should we just make get_current_key async like we did with _serialize_payload in #7987?

@erikjohnston
Copy link
Member

Notable that most of these functions weren't returning a Deferred anymore, it seems only the RoomEventSource.get_current_key() does. The rest just return integers.

This seems like it could lead to confusion. Should we just make get_current_key async like we did with _serialize_payload in #7987?

I think if you follow the call flow all the way down you eventually reach a non-async function, so I would say no. The call stack for getting the current stream position for events is unnecessarily complicated and needlessly jumps through ten layers, but it should be fairly easy to simplify down to a single sync call.

@clokep
Copy link
Member Author

clokep commented Aug 3, 2020

I added a couple more changes:

  • Converted get_room_events_max_id to async/await.
  • Make RoomEventSource.get_current_key sync and then propagate this back to EventSources.get_current_token and EventSources.get_current_token_for_pagination.

anoadragon453
anoadragon453 approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Yay for dropping an unnecessary async call.

@clokep clokep merged commit e19de43 into develop Aug 4, 2020
@clokep clokep deleted the clokep/async-streams branch August 4, 2020 11:21
@clokep clokep mentioned this pull request Aug 6, 2020
Closed
48 tasks
reivilibre added a commit that referenced this pull request Aug 13, 2020
@reivilibre
Merge tag 'v1.19.0rc1' into develop
bfd79c2 
Synapse 1.19.0rc1 (2020-08-13)
==============================

Removal warning
---------------

As outlined in the [previous release](https://github.com/matrix-org/synapse/releases/tag/v1.18.0), we are no longer publishing Docker images with the `-py3` tag suffix. On top of that, we have also removed the `latest-py3` tag. Please see [the announcement in the upgrade notes for 1.18.0](https://github.com/matrix-org/synapse/blob/develop/UPGRADE.rst#upgrading-to-v1180).

Features
--------

- Add option to allow server admins to join rooms which fail complexity checks. Contributed by @lugino-emeritus. ([\#7902](#7902))
- Add an option to purge room or not with delete room admin endpoint (`POST /_synapse/admin/v1/rooms/<room_id>/delete`). Contributed by @dklimpel. ([\#7964](#7964))
- Add rate limiting to users joining rooms. ([\#8008](#8008))
- Add a `/health` endpoint to every configured HTTP listener that can be used as a health check endpoint by load balancers. ([\#8048](#8048))
- Allow login to be blocked based on the values of SAML attributes. ([\#8052](#8052))
- Allow guest access to the `GET /_matrix/client/r0/rooms/{room_id}/members` endpoint, according to MSC2689. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#7314](#7314))

Bugfixes
--------

- Fix a bug introduced in Synapse v1.7.2 which caused inaccurate membership counts in the room directory. ([\#7977](#7977))
- Fix a long standing bug: 'Duplicate key value violates unique constraint "event_relations_id"' when message retention is configured. ([\#7978](#7978))
- Fix "no create event in auth events" when trying to reject invitation after inviter leaves. Bug introduced in Synapse v1.10.0. ([\#7980](#7980))
- Fix various comments and minor discrepencies in server notices code. ([\#7996](#7996))
- Fix a long standing bug where HTTP HEAD requests resulted in a 400 error. ([\#7999](#7999))
- Fix a long-standing bug which caused two copies of some log lines to be written when synctl was used along with a MemoryHandler logger. ([\#8011](#8011), [\#8012](#8012))

Updates to the Docker image
---------------------------

- We no longer publish Docker images with the `-py3` tag suffix, as [announced in the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/UPGRADE.rst#upgrading-to-v1180). ([\#8056](#8056))

Improved Documentation
----------------------

- Document how to set up a client .well-known file and fix several pieces of outdated documentation. ([\#7899](#7899))
- Improve workers docs. ([\#7990](#7990), [\#8000](#8000))
- Fix typo in `docs/workers.md`. ([\#7992](#7992))
- Add documentation for how to undo a room shutdown. ([\#7998](#7998), [\#8010](#8010))

Internal Changes
----------------

- Reduce the amount of whitespace in JSON stored and sent in responses. Contributed by David Vo. ([\#7372](#7372))
- Switch to the JSON implementation from the standard library and bump the minimum version of the canonicaljson library to 1.2.0. ([\#7936](#7936), [\#7979](#7979))
- Convert various parts of the codebase to async/await. ([\#7947](#7947), [\#7948](#7948), [\#7949](#7949), [\#7951](#7951), [\#7963](#7963), [\#7973](#7973), [\#7975](#7975), [\#7976](#7976), [\#7981](#7981), [\#7987](#7987), [\#7989](#7989), [\#8003](#8003), [\#8014](#8014), [\#8016](#8016), [\#8027](#8027), [\#8031](#8031), [\#8032](#8032), [\#8035](#8035), [\#8042](#8042), [\#8044](#8044), [\#8045](#8045), [\#8061](#8061), [\#8062](#8062), [\#8063](#8063), [\#8066](#8066), [\#8069](#8069), [\#8070](#8070))
- Move some database-related log lines from the default logger to the database/transaction loggers. ([\#7952](#7952))
- Add a script to detect source code files using non-unix line terminators. ([\#7965](#7965), [\#7970](#7970))
- Log the SAML session ID during creation. ([\#7971](#7971))
- Implement new experimental push rules for some users. ([\#7997](#7997))
- Remove redundant and unreliable signature check for v1 Identity Service lookup responses. ([\#8001](#8001))
- Improve the performance of the register endpoint. ([\#8009](#8009))
- Reduce less useful output in the newsfragment CI step. Add a link to the changelog section of the contributing guide on error. ([\#8024](#8024))
- Rename storage layer objects to be more sensible. ([\#8033](#8033))
- Change the default log config to reduce disk I/O and storage for new servers. ([\#8040](#8040))
- Add an assertion on `prev_events` in `create_new_client_event`. ([\#8041](#8041))
- Add a comment to `ServerContextFactory` about the use of `SSLv23_METHOD`. ([\#8043](#8043))
- Log `OPTIONS` requests at `DEBUG` rather than `INFO` level to reduce amount logged at `INFO`. ([\#8049](#8049))
- Reduce amount of outbound request logging at `INFO` level. ([\#8050](#8050))
- It is no longer necessary to explicitly define `filters` in the logging configuration. (Continuing to do so is redundant but harmless.) ([\#8051](#8051))
- Add and improve type hints. ([\#8058](#8058), [\#8064](#8064), [\#8060](#8060), [\#8067](#8067))
babolivier pushed a commit that referenced this pull request Sep 1, 2021
@anoadragon453
Merge commit 'e19de43eb' into anoa/dinsic_release_1_21_x
04fef33 
* commit 'e19de43eb':
  Convert streams to async. (#8014)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clokep @anoadragon453 @erikjohnston