This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Use store.get_users_in_room rather than state handler in typing for speed #7856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
reviewed
Jul 15, 2020
synapse/handlers/typing.py
Outdated
| @@ -185,7 +185,7 @@ def _push_update(self, member, typing): | |||
|
|
|||
| async def _push_remote(self, member, typing): | |||
| try: | |||
| users = await self.state.get_current_users_in_room(member.room_id) | |||
| users = await self.state.get_users_in_room(member.room_id) | |||
There was a problem hiding this comment.
Should this be self.store instead of self.state?
There was a problem hiding this comment.
sigh, here I thought was a PR I couldn't mess up...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might give us a small performance improvement, since
get_users_in_roomwill be cached at a higher layer (and doesn't do state res if it isn't cached).