Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix new metric where we used ms instead of seconds #7771

Merged
merged 2 commits into from
Jul 1, 2020

Conversation

erikjohnston
Copy link
Member

Introduced in #7755, not yet released.

@erikjohnston erikjohnston force-pushed the erikj/fix_new_metric branch from 90d28ed to 1755c98 Compare July 1, 2020 13:40
@erikjohnston erikjohnston changed the base branch from develop to release-v1.16.0 July 1, 2020 13:41
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems OK! Other calls seem to use the time.time() API which is already in seconds.

@erikjohnston erikjohnston merged commit 1e03513 into release-v1.16.0 Jul 1, 2020
@erikjohnston erikjohnston deleted the erikj/fix_new_metric branch July 1, 2020 14:24
clokep added a commit that referenced this pull request Jul 2, 2020
Synapse 1.16.0rc2 (2020-07-02)
==============================

Synapse 1.16.0rc2 includes the security fixes released with Synapse 1.15.2.
Please see [below](https://github.com/matrix-org/synapse/blob/master/CHANGES.md#synapse-1152-2020-07-02) for more details.

Improved Documentation
----------------------

- Update postgres image in example `docker-compose.yaml` to tag `12-alpine`. ([\#7696](#7696))

Internal Changes
----------------

- Add some metrics for inbound and outbound federation latencies: `synapse_federation_server_pdu_process_time` and `synapse_event_processing_lag_by_event`. ([\#7771](#7771))
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit '5cdca53aa':
  Merge different Resource implementation classes (#7732)
  Fix inconsistent handling of upper and lower cases of email addresses. (#7021)
  Allow YAML config file to contain None (#7779)
  Fix a typo.
  Move 1.15.2 after 1.16.0rc2.
  1.16.0rc2
  Remove an extraneous space.
  Add links to the fixes.
  Fix tense in the release notes.
  Hack to add push priority to push notifications (#7765)
  Add early returns to `_check_for_soft_fail` (#7769)
  Use symbolic names for replication stream names (#7768)
  Type checking for `FederationHandler` (#7770)
  Fix new metric where we used ms instead of seconds (#7771)
  Fix incorrect error message when database CTYPE was set incorrectly. (#7760)
  Pin link in CHANGES.md
  Fixes to CHANGES.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants