This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Kill off some old python 2 code #7519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a no-op on python 3.
this is a no-op on python 3.
this is a no-op under python 3
this is no longer needed on python 3
richvdh
force-pushed
the
rav/kill_py2_code
branch
from
b8c823b to
ab57353
Compare
clokep
approved these changes
May 15, 2020
| @@ -72,7 +67,7 @@ def rows_v2(server, json): | |||
| valid_until = json["valid_until_ts"] | |||
| key_json = encode_canonical_json(json) | |||
| for key_id in json["verify_keys"]: | |||
| yield (server, key_id, "-", valid_until, valid_until, db_type(key_json)) | |||
| yield (server, key_id, "-", valid_until, valid_until, db_binary_type(key_json)) | |||
There was a problem hiding this comment.
Curious why you didn't just use memoryview directly here (and some other places)?
There was a problem hiding this comment.
I kinda felt like maybe the abstraction was useful. I went back and forth on it a bit 🤷♂️
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stuff has been annoying me for a while.
Each commit should stand alone.
(There's plenty more that can be removed; this was just what I found in 10 minutes.)