Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

fix mypy for tests.replication #7518

Merged
merged 1 commit into from
May 18, 2020
Merged

fix mypy for tests.replication #7518

merged 1 commit into from
May 18, 2020

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented May 15, 2020 •
edited
Loading

No description provided.

@richvdh richvdh requested a review from a team May 15, 2020 17:51
clokep
clokep approved these changes May 15, 2020
View reviewed changes
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a bit odd to mix asserts and unittest style tests, but if it makes mypy happy that's good!

@richvdh richvdh merged commit 164f50f into develop May 18, 2020
@richvdh richvdh deleted the rav/tests_mypy branch May 18, 2020 09:43
phil-flex pushed a commit to phil-flex/synapse that referenced this pull request Jun 16, 2020
@richvdh @phil-flex
fix mypy for tests/replication (matrix-org#7518)
0748a3f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clokep clokep clokep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richvdh @clokep