This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Update ACME.md to mention ACME v1 deprecation #6905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
approved these changes
Feb 13, 2020
There was a problem hiding this comment.
lgtm otherwise!
I think it would be good (as part of this PR or a separate one) to update https://github.com/matrix-org/synapse/blob/master/INSTALL.md#tls-certificates to point people towards using a reverse proxy, and mention that the ACME support is a bit broken.
Agreed, ftr my plan is to update each config file in its own PR to ease review so I'll probably do it in a separate PR. |
babolivier
added a commit
that referenced
this pull request
Feb 13, 2020
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit 'f48bf4feb': Update docs/ACME.md Mention that using Synapse to serve certificates requires restarts Changelog Remove duplicated info about certbot et al Update ACME.md to mention ACME v1 deprecation
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit 'df1c98c22': Update changelog for #6905 to group it with upcoming PRs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't sure what to do with the part regarding the initial setup, I decided to keep it in case we can support ACMEv2 in a timely manner.