This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Log saml assertions rather than the whole response #6724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... since the whole response is huge. We even need to break up the assertions, since kibana otherwise truncates them.
erikjohnston
approved these changes
Jan 17, 2020
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '59dc87c61': changelog Log saml assertions rather than the whole response move batch_iter to a separate module
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... since the whole response is huge.
We even need to break up the assertions, since kibana otherwise truncates them.
There are two commits here; the first is a non-functional refactor moving
batch_iterinto a newiterutilsmodule, which we then addchunk_seqto.