Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

contrib/docker-compose: fix mount that overrides containers' /etc #6656

Merged
merged 4 commits into from
Jan 8, 2020
Merged

contrib/docker-compose: fix mount that overrides containers' /etc #6656

merged 4 commits into from
Jan 8, 2020

Conversation

faaaaabi
Copy link
Contributor

@faaaaabi faaaaabi commented Jan 7, 2020 •
edited
Loading

The mount in the form of ./matrix-config:/etc overwrites the contents of the container /etc folder. Since all valid ca certificates are stored in /etc, the synapse.push.httppusher, for example, cannot validate the certificate from matrix.org.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file
  • Pull request includes a sign off
  • Code style is correct (run the linters)

@faaaaabi
fixing mount that overrides containers /etc
131bd5e 
The mount in the form of ./matrix-config:/etc overwrites the contents of the container /etc folder. Since all valid ca certificates are stored in /etc, the synapse.push.httppusher, for example, cannot validate the certificate from matrix.org.
@faaaaabi
add changelog
ee99f16
@faaaaabi
Copy link
Contributor Author

faaaaabi commented Jan 7, 2020

Signed-off-by: Fabian Meyer [email protected]

@faaaaabi
Copy link
Contributor Author

faaaaabi commented Jan 7, 2020

I created the issue #6650

After that I continued investigating for the reason why the Riot.im Android app did not receive any push notifications. I found out that the proposed docker-compose.yaml mounts a folder with the destination "/etc". This lead to the containers "/etc" folder to be completely overridden. As all trusted ca-certs are also stored under "etc" this seemingly caused the issue with the push notifications. After I only mounting the homeserver.yaml to "/etc", synapse was able to send push notifications

@faaaaabi faaaaabi marked this pull request as ready for review January 7, 2020 18:51
richvdh
richvdh reviewed Jan 7, 2020
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh gosh, yes, that would do it. Thanks for investigating and figuring out the solution!

one minor change below

changelog.d/6656.bugfix Outdated Show resolved Hide resolved
@faaaaabi
Copy link
Contributor Author

faaaaabi commented Jan 8, 2020

Sure 😊

@richvdh richvdh changed the title fixing mount that overrides containers /etc contrib/docker-compose: fix mount that overrides containers' /etc Jan 8, 2020
richvdh
richvdh approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@richvdh richvdh merged commit dd57715 into matrix-org:develop Jan 8, 2020
@richvdh richvdh mentioned this pull request Jan 8, 2020
Closed
babolivier pushed a commit that referenced this pull request Sep 1, 2021
@anoadragon453
contrib/docker-compose: fixing mount that overrides containers' /etc (…
a7a73bb 
…#6656)

* commit 'dd57715de':
  contrib/docker-compose: fixing mount that overrides containers' /etc (#6656)
  typo
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faaaaabi @richvdh