This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Cross-signing [1/4] -- hidden devices #5759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a prerequisite for cross-signing, as it allows us to create other things that live within the device namespace, so they can be used for signatures.
richvdh
reviewed
Jul 30, 2019
richvdh
reviewed
Jul 30, 2019
synapse/storage/devices.py
Outdated
| ) | ||
| sql = """ | ||
| DELETE FROM devices | ||
| WHERE user_id = ? AND device_id = ? AND NOT COALESCE(hidden, ?) |
There was a problem hiding this comment.
having looked at how this works out, I'm really sorry but I think I'm going to revise my original comments here; it's just too awkward. I think the 30s or so it's going to take to add a NOT NULL column to the table will be worth it for not jumping through these hoops and having to manage a tristate.
Really sorry for vacillating on this.
richvdh
reviewed
Jul 30, 2019
| @@ -0,0 +1,18 @@ | |||
| /* Copyright 2019 New Vector Ltd | |||
There was a problem hiding this comment.
can you give this delta file a different name?
Codecov Report
@@ Coverage Diff @@
## develop #5759 +/- ##
===========================================
- Coverage 63.44% 63.42% -0.02%
===========================================
Files 331 331
Lines 36515 36520 +5
Branches 6035 6038 +3
===========================================
- Hits 23167 23164 -3
- Misses 11704 11710 +6
- Partials 1644 1646 +2 |
uhoreg
force-pushed
the
uhoreg/e2e_cross-signing2-part0
branch
from
095524e to
c1f0a56
Compare
(by going back to not using SQL directly)
erikjohnston
approved these changes
Aug 9, 2019
uhoreg
changed the base branch from
develop
to
uhoreg/e2e_cross-signing_merged
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for cross-signing, as it allows us to create other things
that live within the device namespace, so they can be used for signatures.
(This is split off from #4970)