Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

store_server_verify_keys shouldn't need to lock the table #3819

Closed
richvdh opened this issue Sep 6, 2018 · 1 comment
Closed

store_server_verify_keys shouldn't need to lock the table #3819

richvdh opened this issue Sep 6, 2018 · 1 comment
Labels
A-Federation A-Performance Performance, both client-facing and admin-facing z-p2 (Deprecated Label)

Comments

@richvdh
Copy link
Member

richvdh commented Sep 6, 2018

the table has a unique key, so the update-insert loop technique should work fine. Using a lock serialises the updates when we first join a big room
This was referenced Sep 6, 2018
Closed
Closed
Closed
@neilisfragile neilisfragile added A-Performance Performance, both client-facing and admin-facing z-p2 (Deprecated Label) labels Oct 5, 2018
@richvdh
Copy link
Member Author

richvdh commented Apr 2, 2019

I guess this is made irrelevant by #4306 .

@richvdh richvdh closed this as completed Apr 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Federation A-Performance Performance, both client-facing and admin-facing z-p2 (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@neilisfragile @richvdh @hawkowl @DMRobertson