Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Run actions/setup-go after checking out complement #16567

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

DMRobertson
Copy link
Contributor

@DMRobertson DMRobertson commented Oct 28, 2023

This should suppress the warnings in test runs, e.g. from https://github.com/matrix-org/synapse/actions/runs/6673818366?pr=16565
image

and presumably make it mildly quicker to prepare the complement test binary.

@DMRobertson
Copy link
Contributor Author

Let's see if this works by checking https://github.com/matrix-org/synapse/actions/runs/6678497686?pr=16567

@DMRobertson DMRobertson marked this pull request as ready for review October 28, 2023 18:38
@DMRobertson DMRobertson requested a review from a team as a code owner October 28, 2023 18:38
@clokep
Copy link
Member

clokep commented Oct 29, 2023

Still has a warning about go version but unsure we care?

@DMRobertson
Copy link
Contributor Author

DMRobertson commented Oct 29, 2023

Still has a warning about go version but unsure we care?

Namely:

image

I think I can fix that too, while I'm at it.

@DMRobertson DMRobertson requested a review from clokep October 29, 2023 20:45
@clokep
Copy link
Member

clokep commented Oct 30, 2023

Complement seems to be failing now?

@DMRobertson
Copy link
Contributor Author

My bet is that the go version declared in complement's go.mod is too low. Which seems like a surprising oversight, but should be easy enough to fix.

@clokep
Copy link
Member

clokep commented Oct 30, 2023

My bet is that the go version declared in complement's go.mod is too low. Which seems like a surprising oversight, but should be easy enough to fix.

Sounds like an oversight in the complement CI too then?

@DMRobertson
Copy link
Contributor Author

DMRobertson commented Oct 30, 2023

My bet is that the go version declared in complement's go.mod is too low. Which seems like a surprising oversight, but should be easy enough to fix.

Sounds like an oversight in the complement CI too then?

More like in complement's dependency/project definitions, but otherwise yes. matrix-org/complement#687 should fix.

@DMRobertson
Copy link
Contributor Author

complement change landed. Rerunning.

@DMRobertson
Copy link
Contributor Author

Complement seems happier now.

@DMRobertson DMRobertson merged commit 4e1a19d into develop Oct 30, 2023
36 of 38 checks passed
@DMRobertson DMRobertson deleted the dmr/complement-restore-cache branch October 30, 2023 13:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants