Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

We should remove Caddy from the workerised Complement container image, because it's confusing having both Nginx and Caddy #12816

Closed
reivilibre opened this issue May 20, 2022 · 0 comments · Fixed by #12818
Assignees
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@reivilibre
Copy link
Contributor

Our current Complement-with-workers image uses Nginx to route worker requests to the right worker and uses Caddy to do TLS termination.

Whilst it's convenient that Caddy can generate the TLS certificate on-demand (I guess), it's frustrating that it's configured with a very messy and under-documented JSON file.
It's also confusing that we use two reverse-proxies in the same image.

Nginx can terminate TLS just fine and a handful of OpenSSL commands can generate a certificate (this is what the non-workerised version does), so I think it'd be cleaner to get rid of Caddy from the 'architecture' of our worker image.

@reivilibre reivilibre added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label May 20, 2022
@reivilibre reivilibre self-assigned this May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant