Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Overly aggressive purging of get_users_in_room cache? #11875

Closed
clokep opened this issue Feb 1, 2022 · 0 comments · Fixed by #11878
Closed

Overly aggressive purging of get_users_in_room cache? #11875

clokep opened this issue Feb 1, 2022 · 0 comments · Fixed by #11878
Assignees
@clokep
Labels
A-Performance Performance, both client-facing and admin-facing T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@clokep
Copy link
Member

clokep commented Feb 1, 2022

We invalidate the get_users_in_room cache (and a few others) as part of _invalidate_state_caches, we calculate a members_changed with the comment:

Figure out the changes of membership to invalidate the get_rooms_for_user cache.

But don't seem to be using it in the opposite direction (get_users_for_room).

tl;dr I think we are invalidating this cache in situations we do not need to.
@clokep clokep added the T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. label Feb 1, 2022
@richvdh richvdh added the A-Performance Performance, both client-facing and admin-facing label Feb 1, 2022
@clokep clokep mentioned this issue Feb 1, 2022
Merged
@clokep clokep self-assigned this Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@clokep clokep

Labels
A-Performance Performance, both client-facing and admin-facing T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only clear the get_users_in_room caches when necessary. matrix-org/synapse
2 participants
@clokep @richvdh