You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Related to #11583 -- currently when we generate a sync response we cache it for a period of time (as clients sometimes timeout and retry). Unfortunately the bundled aggregations are added during the serialization step, which occurs after caching, and is re-done even when using a cached response.
Ideally we should be calculating the bundled aggregations earlier in a different manner and the serialization methods should be synchronous.
My hope with the above is that we can avoid this problem for other APIs too, if it exists. Note that we need to be careful though since events get cached and modifying them will modify a shared copy.
Related to #11583 -- currently when we generate a sync response we cache it for a period of time (as clients sometimes timeout and retry). Unfortunately the bundled aggregations are added during the serialization step, which occurs after caching, and is re-done even when using a cached response.
Ideally we should be calculating the bundled aggregations earlier in a different manner and the serialization methods should be synchronous.
See https://matrix.to/#/!XaqDhxuTIlvldquJaV:matrix.org/$1E_K64Dd5p6iFMS4agak62bn5JZl3Ry-6XiTXYzOmhU?via=matrix.org&via=vector.modular.im&via=envs.net for a brief conversation around this.
The text was updated successfully, but these errors were encountered: