Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Update generated URLs to point to v3 #11474

Open
clokep opened this issue Dec 1, 2021 · 0 comments
Open

Update generated URLs to point to v3 #11474

clokep opened this issue Dec 1, 2021 · 0 comments
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@clokep
Copy link
Member

clokep commented Dec 1, 2021

Related to #11079, we generate some URLs internally that point to r0 URLs, some places we do this is for:

  • Callback URLs used in SSO
  • Attempting to fetch media from remote servers

Maybe other places. We should eventually update these to use v3 URLs. The ones that generate URLs that go back to ourselves should be easy enough (if people have their reverse proxies configured properly), but the ones to other servers are a bit more complicated. For federation we try v2 URLs then fallback to v1 URLs, but that's rather annoying. Not sure if there's something better to do.

@clokep clokep added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Dec 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

No branches or pull requests

1 participant