Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This module blocks Synapse while waiting for Sydent to respond to the bind/unbind request #5

Open
anoadragon453 opened this issue Feb 28, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@anoadragon453
Copy link
Member

Synapse will await on the module API callbacks that this module relies on, which blocks Synapse's execution on this module's code. Since this module makes HTTP requests to an external process (Sydent), if that external server is taking a while to respond, this can cause Synapse to in turn respond slowly to client requests.

Since this module relies on Synapse module API methods that only fire after a third-party ID is successfully added or removed (removed functionality added in #3), such callbacks should immediately relinquish control back to Synapse and then in a separate thread go and send a request to Sydent and wait for a response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant