Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surprising no-op DELETE when injecting a new room into a list #138

Open
DMRobertson opened this issue May 31, 2023 · 1 comment
Open

Surprising no-op DELETE when injecting a new room into a list #138

DMRobertson opened this issue May 31, 2023 · 1 comment
Labels

Comments

@DMRobertson
Copy link
Contributor

  • With a clean account, create room A.
  • Request an initial sliding sync, sorting by recency and subscribing to the window [0, 1].
  • Response has a single op:
    • SYNC(0, 0, roomA).
  • Create a new room B.
  • Response has two ops:
    • DELETE(1)
    • INSERT(0, roomB)

The delete is surprising since there isn't anything there are the time. This reminds me of #52

@kegsay
Copy link
Member

kegsay commented Jun 2, 2023

It's also not wrong which is confusing. The reason why it exists is because server-side when you join a new room it is literally added to the end of the list, and then the position recalculated, causing a DELETE at the end of the list.

@kegsay kegsay added the api label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants