Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InvisibleCrypto | Share Room Keys: Refactoring, create a new Trait to collect session recipients and refactor to allow for a future strategy based on identity #3562

Closed
BillCarsonFr opened this issue Jun 17, 2024 · 0 comments · Fixed by #3605
Closed

InvisibleCrypto | Share Room Keys: Refactoring, create a new Trait to collect session recipients and refactor to allow for a future strategy based on identity #3562

BillCarsonFr opened this issue Jun 17, 2024 · 0 comments · Fixed by #3605
Assignees
@BillCarsonFr
Labels
encryption

Comments

@BillCarsonFr
Copy link
Member

BillCarsonFr commented Jun 17, 2024 •
edited by richvdh
Loading

As part of Invisible Crypto.

No functionality change. This a first step that would allow next to add a new strategy when distributing keys.

Notes from https://github.com/element-hq/crypto-internal/issues/307:

Prep-work Refactor GroupSessionManager#collect_session_recipients and extract a trait responsible of collecting the target devices (RoomKeyShareStrategy trait). No changes on functionality
@BillCarsonFr BillCarsonFr mentioned this issue Jun 17, 2024
Closed
@BillCarsonFr BillCarsonFr changed the title Share Room Keys | Refactoring, create a new Trait to collect sessions recipient and refactor to allow for a future strategy based on identity Share Room Keys | InvisibleCrypto: Refactoring, create a new Trait to collect sessions recipient and refactor to allow for a future strategy based on identity Jun 17, 2024
@richvdh richvdh changed the title Share Room Keys | InvisibleCrypto: Refactoring, create a new Trait to collect sessions recipient and refactor to allow for a future strategy based on identity Share Room Keys | InvisibleCrypto: Refactoring, create a new Trait to collect session recipients and refactor to allow for a future strategy based on identity Jun 17, 2024
This was referenced Jun 18, 2024
Closed
Merged
@richvdh richvdh changed the title Share Room Keys | InvisibleCrypto: Refactoring, create a new Trait to collect session recipients and refactor to allow for a future strategy based on identity InvisibleCrypto | Share Room Keys: Refactoring, create a new Trait to collect session recipients and refactor to allow for a future strategy based on identity Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BillCarsonFr BillCarsonFr

Labels
encryption
Projects
None yet
Milestone
No milestone
1 participant
@BillCarsonFr