MSC2918: Refresh tokens #2918
Merged
MSC2918: Refresh tokens #2918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
reviewed
Dec 18, 2020
turt2live
added
kind:feature
turt2live
changed the title
This was referenced Feb 19, 2021
richvdh
reviewed
May 4, 2021
|
Just pushed two changes:
|
richvdh
reviewed
Jun 2, 2021
sandhose
commented
Jun 3, 2021
There was a problem hiding this comment.
A few recent changes:
- d433e3b specify what error code should be used related to this)
- b320001 suggest what to do with refresh token revocation on use (this is what is implemented in Synapse)
- 87566c3 clarify that it also applies to ASes
turt2live
added
the
needs-implementation
sandhose
commented
Jun 17, 2021
There was a problem hiding this comment.
I'm pretty confortable with the current state of the MSC. The implementation in Synapse is pretty much done and working (matrix-org/synapse#9450) and in a working state in Hydrogen (element-hq/hydrogen-web#235).
richvdh
removed
the
needs-implementation
This was referenced Feb 15, 2022
turt2live
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Feb 15, 2022
MSC: matrix-org/matrix-spec-proposals#2918 Fixes element-hq/element-web#18698 Fixes element-hq/element-web#20648 **Requires matrix-org/matrix-js-sdk#2178 **Note**: There's a lot of logging in this PR. That is intentional to ensure that if/when something goes wrong we can chase the exact code path. It does not log any tokens - just where the code is going. Overall, it should be fairly low volume spam (and can be relaxed at a later date). ---- This approach uses indexeddb (through a mutex library) to manage which tab actually triggers the refresh, preventing issues where multiple tabs try to update the token. If multiple tabs update the token then the server might consider the account hacked and hard logout all the tokens. If for some reason the timer code gets it wrong, or the user has been offline for too long and the token can't be refreshed, they should be sent to a soft logout screen by the server. This will retain the user's encryption state - they simply need to reauthenticate to get an active access token again. This additionally contains a change to fix soft logout not working, per the issue links above. Of interest may be the IPC approach which was ultimately declined in favour of this change instead: #7803
|
FTR, I'm working on the spec PR for this |
15 tasks
|
Spec PR: matrix-org/matrix-spec#1056 |
turt2live
added
spec-pr-in-review
uhoreg
added
merged
|
merged! 🎉 |
66 tasks
|
I've added Element Web and iOS implementations of this MSC to the PR description. |
|
@anoadragon453 ftr, the web implementation was reverted: matrix-org/matrix-react-sdk#7821 |
|
Oh, thanks for letting me know! |
16 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
Related: matrix-org/matrix-spec#410, matrix-org/matrix-spec#636
Implementations: synapse, hydrogen,
Element Web/Desktop(reverted), Element iOSFCP proposal: #2918 (comment)