Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

what does a push rule tweak of sound with no value do? #650

Open
richvdh opened this issue Jun 19, 2020 · 4 comments
Open

what does a push rule tweak of sound with no value do? #650

richvdh opened this issue Jun 19, 2020 · 4 comments
Labels
A-Client-Server Issues affecting the CS API A-Push clarification An area where the expected behaviour is understood, but the spec could do with being more explicit

Comments

@richvdh
Copy link
Member

richvdh commented Jun 19, 2020

What happens if I add an action of {"set_tweak": "sound"} (with no value) to a push rule? Is it rejected by the server? is it the same as value: default? or the same as not setting the tweak at all?
@richvdh
Copy link
Member Author

richvdh commented Jun 19, 2020

Synapse certainly seems to allow it. As per matrix-org/sygnal#107, sygnal no longer cares about the sound tweak, and the behaviour is determined by the client.

@richvdh richvdh added clarification An area where the expected behaviour is understood, but the spec could do with being more explicit A-Push A-Client-Server Issues affecting the CS API labels Jun 19, 2020
@richvdh
Copy link
Member Author

richvdh commented Jun 19, 2020

riot-web doesn't care about the value: https://github.com/matrix-org/matrix-react-sdk/blob/227fc24d3aedba79a30eaf3963a9e9e8fefcba2a/src/Notifier.js#L374

@t3chguy
Copy link
Member

t3chguy commented Jun 19, 2020

though if value was null then riot-web would not play audio https://github.com/matrix-org/matrix-js-sdk/blob/be05452c7031a1d2f2dfdaeca153808665763c83/src/pushprocessor.js#L407-L410

@richvdh
Copy link
Member Author

richvdh commented Jun 19, 2020

riotX treats it the same as {"set_tweak": "sound", "value": "default"}. riot-iOS, on the other hand, will ignore the tweak if no value is given: https://github.com/vector-im/riot-ios/blob/e4cd215e1b4e8f3e9a41961ff0ee6290b8588423/Riot/Managers/PushNotification/PushNotificationService.m#L572-L576.

@richvdh richvdh mentioned this issue Jul 1, 2020
Merged
4 tasks
@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Client-Server Issues affecting the CS API A-Push clarification An area where the expected behaviour is understood, but the spec could do with being more explicit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richvdh @t3chguy