Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users are missing messages when their Slack token expires #683

Open
tadzik opened this issue May 20, 2022 · 0 comments
Open

Users are missing messages when their Slack token expires #683

tadzik opened this issue May 20, 2022 · 0 comments
Labels
S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.

Comments

@tadzik
Copy link
Contributor

tadzik commented May 20, 2022

If, for any reason, user's Slack token expires (giving us a this error:

WARN SlackClientFactory Failed to auth puppeted client for user: Error: An API error occurred: token_revoked
    at Object.platformErrorFromResult (/usr/src/app/node_modules/@slack/web-api/dist/errors.js:51:33)
    at WebClient.apiCall (/usr/src/app/node_modules/@slack/web-api/dist/WebClient.js:156:28)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async SlackClientFactory.getClientForUserWithId (/usr/src/app/lib/SlackClientFactory.js:182:26)
    at async SlackClientFactory.getClientForUser (/usr/src/app/lib/SlackClientFactory.js:200:21)
    at async Main.startupLoadRoomEntry (/usr/src/app/lib/Main.js:1041:31)
    at async /usr/src/app/lib/Main.js:986:17
    at async Promise.all (index 659)
    at async Main.run (/usr/src/app/lib/Main.js:983:9) {
  code: 'slack_webapi_platform_error',
  data: { ok: false, error: 'token_revoked', response_metadata: {} }
}

), we're not notifying users in any way – they will still see messages on public channels, but not in DMs – making them feel like the bridge is broken rather than assuming that they lost access. We should be handling these errors properly, notifying the affected users that they need to re-login to Slack to be able to use the bridge.

matrix-org/matrix-appservice-bridge#400 may be a useful prerequisite for this.

@tadzik tadzik added S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems. labels May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.
Projects
None yet
Development

No branches or pull requests

1 participant