Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable room topic echos from Matrix #836

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

Miepee
Copy link
Contributor

@Miepee Miepee commented Aug 24, 2022

This PR adds another config value, in order to disable forwarding room topic echos on Matrix to Discord.

@Miepee Miepee requested a review from a team as a code owner August 24, 2022 17:36
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but can you add a test next to https://github.com/matrix-org/matrix-appservice-discord/blob/develop/test/test_matrixeventprocessor.ts#L345-L356? I think all you need to do is modify the createMatrixEventProcessor function to take a parameter which customises the config, and then test for no topic notifs.

Thanks!

@Miepee
Copy link
Contributor Author

Miepee commented Aug 26, 2022

I originally didn't add a test case, because the join/leave and invite echos don't have a test case either for not sending a message when the config has it disabled.
Should I add the test cases for those too then?

@Half-Shot
Copy link
Contributor

I originally didn't add a test case, because the join/leave and invite echos don't have a test case either for not sending a message when the config has it disabled. Should I add the test cases for those too then?

That's definitely an oversight. Extra points if you do those too, but I'm also happy just to accept changes for the things you tested.

@Miepee Miepee requested a review from Half-Shot August 26, 2022 11:26
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Half-Shot Half-Shot enabled auto-merge (squash) September 2, 2022 09:27
@Half-Shot Half-Shot merged commit 942f912 into matrix-org:develop Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants