Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yarn.lock and fix Docker builds #825

Merged
merged 9 commits into from
Aug 9, 2022
Merged

Update yarn.lock and fix Docker builds #825

merged 9 commits into from
Aug 9, 2022

Conversation

jaller94
Copy link
Contributor

@jaller94 jaller94 commented Aug 8, 2022

@jaller94 jaller94 requested a review from a team as a code owner August 8, 2022 11:47
@jaller94
Copy link
Contributor Author

jaller94 commented Aug 8, 2022

With 3e491ca this is now a breaking change that requires a new major version.

Because of the library matrix-appservice-bridge v5.0.0 the supported Node.js versions are 16 and 18.

Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to be explicit about all the versions we support, 16 is the headline. Otherwise, lgtm.

@@ -0,0 +1 @@
Require Node.js 16, 17 or 18 to run. Update yarn.lock and fix Docker builds.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Require Node.js 16, 17 or 18 to run. Update yarn.lock and fix Docker builds.
Minimum required Node.js version is now 16.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to be a .removal to indicate that it's a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yarn.lock seems out of sync for v2.0.0
2 participants