-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update yarn.lock and fix Docker builds #825
Conversation
With 3e491ca this is now a breaking change that requires a new major version. Because of the library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to be explicit about all the versions we support, 16 is the headline. Otherwise, lgtm.
changelog.d/825.misc
Outdated
@@ -0,0 +1 @@ | |||
Require Node.js 16, 17 or 18 to run. Update yarn.lock and fix Docker builds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Require Node.js 16, 17 or 18 to run. Update yarn.lock and fix Docker builds. | |
Minimum required Node.js version is now 16. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also needs to be a .removal
to indicate that it's a breaking change.
yarn.lock
seems out of sync for v2.0.0 #824python
topython3
#798matrix-appservice-bridge
to v5.0.0 which requires Node.js 16, 17 or 18