Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_ensureJoined should check for actual membership if cache returns nothing #499

Open
austinhuang0131 opened this issue Jun 2, 2024 · 0 comments

Comments

@austinhuang0131
Copy link

austinhuang0131 commented Jun 2, 2024

In Intent#_ensureJoined, after cache returns anything that's not "join", the intent would immediately try to join the room. However, since cache is cleared on each restart, if cache returns null, then the intent does not know whether it is actually in a room or not. This creates some issues:

I can provide a pull request. Please reconsider. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant