You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I recently added this to the draupnir (mjolnir fork) appservice, and it is quite interesting, however since it uses the lib it is missing some parts in between currently. It would be nice to have spans for functions of the library. I am not sure what the best way to add them would be. In draupnir I used custom decorators. However, typescript 4 (stage 2) decorators are fairly limiting, so they only work for some functions (mainly class methods). (See https://github.com/MTRNord/Draupnir/blob/76f0433c246a9c91f31ad45f81d6b6aab2f19897/src/utils.ts#L508-L608 for example decorators that wrap nested or not nested spans around methods in classes).
The code I did results in this picture on incoming transactions:
Ideally, it would be nice to also get insight to what this sdk does to have better insight on potential areas that may have room for improvement in draupnir4all/appservices.
The text was updated successfully, but these errors were encountered:
Hi,
for lack of a room to ask in :D
Would it make sense to add opentelemtry to this library? https://opentelemetry.io/docs/instrumentation/js/
I recently added this to the draupnir (mjolnir fork) appservice, and it is quite interesting, however since it uses the lib it is missing some parts in between currently. It would be nice to have spans for functions of the library. I am not sure what the best way to add them would be. In draupnir I used custom decorators. However, typescript 4 (stage 2) decorators are fairly limiting, so they only work for some functions (mainly class methods). (See https://github.com/MTRNord/Draupnir/blob/76f0433c246a9c91f31ad45f81d6b6aab2f19897/src/utils.ts#L508-L608 for example decorators that wrap nested or not nested spans around methods in classes).
The code I did results in this picture on incoming transactions:
Ideally, it would be nice to also get insight to what this sdk does to have better insight on potential areas that may have room for improvement in draupnir4all/appservices.
The text was updated successfully, but these errors were encountered: