Support extensible events #393
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadzik
reviewed
Feb 17, 2022
| @@ -33,8 +33,8 @@ export class RequestFactory { | |||
| * @param opts The options to pass to the Request constructor, if any. | |||
| * @return A new request object | |||
| */ | |||
| public newRequest<T>(opts?: RequestOpts<T>) { | |||
| const req = new Request(opts || {data: null}); | |||
| public newRequest<T, R extends unknown>(opts?: RequestOpts<T>): Request<T, R> { | |||
There was a problem hiding this comment.
Nitpick: does R extends unknown do anything more than a regular R?
|
Looks good: do we have any bridge currently making use of this, so we can see how the API works out in practice? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #390
Matrix is moving to a new model for events where by messages no longer contain one representation, but a series of fallbacks (known as extensible events) so that applications can choose the best representation.
The bridge sdk will make use of the
matrix-events-sdkto automatically parse and represent these events, and then use a new controller callback to emit these events. This is currently unstable, and so bridges need to explicitly opt in to this behavior to use it.See https://github.com/matrix-org/matrix-events-sdk#readme
See matrix-org/matrix-spec-proposals#1767