-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add markers to basic plot image #27
base: main
Are you sure you want to change the base?
Conversation
If we really want markers over the plot, it should be orange and placed over the sine. Else, it's confusing because it suggests you can to have two different plots with one command. |
With two datasets I want to stress that Side note: You can actually draw two plots with one command (either using |
I don't think we should highlight that particular feature! I agree with @rougier here, the rest of the entries are 1:1 of plotting command to the atomic (ish) graphic you get from that element so am 👎 on this change. I'm 50/50 including a markers on the organge sin and 50/50 on adding another entry to the column, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @rougier that adding a second differently colored dataset is confusing.
The overall motivation is to avoid the association: An important question for the styling is the intended direction of the mapping: Does the section list visual plots and annotate them with the needed command? Or does section list our plot commands and the images are illustrations? Possible solutions:
|
I prefer 1, but I suspect rougier doesn't like the second color. I don't see the confusion with the second data set, or having two |
I think we should keep it simple since we cannot show everything on cheat sheets. Even the markers on the first plot might be confusing. This of course tends to suggest that for scatter plot you have to use the scatter command, but the cheatsheet might be not the place to explain this is not really the case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this time , it will show clearly of plot. I am agree with this code! nice work
Closes #16.
Preview: