Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ast::DateTime::value #6

Open
matklad opened this issue Jul 14, 2018 · 0 comments
Open

Implement ast::DateTime::value #6

matklad opened this issue Jul 14, 2018 · 0 comments
Labels
E-hard Might be tricky to fix needs design I have no idea how to fix it. Feedback is welcome!

Comments

@matklad
Copy link
Owner

matklad commented Jul 14, 2018

It would be great if we had something sensible here:

tom/src/ast/mod.rs

Lines 51 to 56 in 5a1b98e

impl ast::DateTime {
// chrono?
pub fn value(self, _doc: &TomlDoc) -> ::std::time::SystemTime {
unimplemented!()
}
}

The tests for these should go into https://github.com/matklad/tom/blob/5a1b98e0b0b13529a917a9c2212f6813a9eb1948/tests/suite/ast.rs.

I don't know what is the proper design here, what date-time library should we use. Perhaps, just punt on this for a moment?

@matklad matklad added needs design I have no idea how to fix it. Feedback is welcome! E-hard Might be tricky to fix labels Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-hard Might be tricky to fix needs design I have no idea how to fix it. Feedback is welcome!
Projects
None yet
Development

No branches or pull requests

1 participant