Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wallet-provider Release Ready #78

Open
12 of 43 tasks
Elli610 opened this issue Jul 18, 2023 · 0 comments
Open
12 of 43 tasks

Make wallet-provider Release Ready #78

Elli610 opened this issue Jul 18, 2023 · 0 comments

Comments

@Elli610
Copy link
Contributor

Elli610 commented Jul 18, 2023

Objective

The purpose of this issue is to ensure that the library is updated to meet the expected criteria for an application to be maintained and considered release-ready. The requirements are outlined in the Run team procedure: Definition of Release-Ready.

Missing features

  • Add sendTransaction to Account and MassaStationAccount objects
  • Add deploySC to Account and MassaStationAccount objects

Documentation:

Git documentation

Code documentation

Account documentation

Connector documentation

  • improve or add documentation for src/connector/Connector.ts #174
  • improve or add documentation for src/connector/ICustomEventMessageRequest.ts
  • improve or add documentation for src/connector/ICustomEventMessageResponse.ts
  • improve or add documentation for src/connector/IRegisterEvent.ts
  • improve or add documentation for src/connector/index.ts

MassaStation documentation

  • improve or add documentation for src/massaStation/MassaStationAccount.ts
  • improve or add documentation for src/massaStation/MassaStationDiscovery.ts
  • improve or add documentation for src/massaStation/MassaStationProvider.ts
  • improve or add documentation for src/massaStation/RequestHandler.ts

Provider documentation

  • improve or add documentation for src/provider/AccountDeletion.ts
  • improve or add documentation for src/provider/AccountImport.ts
  • improve or add documentation for src/provider/AccountGeneration.ts
  • improve or add documentation for src/provider/IProvider.ts
  • improve or add documentation for src/provider/Provider.ts
  • improve or add documentation for src/provider/index.ts
  • improve or add documentation for src/utils/argsToBase64.ts
  • improve or add documentation for src/utils/time.ts

./src documentation

  • improve or add documentation for src/index.ts

Testing

  • Test src/account/Account.ts
  • Test src/massaStation/MassaStationAccount.ts
  • Test src/massaStation/MassaStationProvider.ts
  • Test Test src/provider/Provider.ts

Security

  • Define a security model
  • Implement proper countermeasures, such as static analysis of code and security checks of dependencies

Automation

  • Automate tasks that can be automated

Must have

Wrap Up

  • Ensure that the Run team procedure was properly applied and update the document if necessary
  • Communicate that the library is now considered release-ready
@Elli610 Elli610 added the Meta issue Meta Issue label Jul 18, 2023
@Elli610 Elli610 changed the title make wallet-provider release ready Make wallet-provider Release Ready Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants