Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1301 use wails for front end #1302

Closed
wants to merge 30 commits into from
Closed

Conversation

thomas-senechal
Copy link
Member

@thomas-senechal thomas-senechal commented Dec 21, 2023

Please do not waste your time reviewing:

  • _test.go files: Mainly changes due to linter update. Tests were not modified.
  • Files in web/massastation/wailsjs/: Those are generated files from Wails.

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

@thomas-senechal thomas-senechal linked an issue Dec 21, 2023 that may be closed by this pull request
@thomas-senechal thomas-senechal force-pushed the 1301-use-wails-for-front-end branch from 51663af to e96876e Compare December 21, 2023 12:50
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e6b206f) 22.09% compared to head (7bfbff4) 22.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1302   +/-   ##
=======================================
  Coverage   22.09%   22.09%           
=======================================
  Files          29       29           
  Lines        1715     1715           
=======================================
  Hits          379      379           
  Misses       1326     1326           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas-senechal thomas-senechal force-pushed the 1301-use-wails-for-front-end branch 6 times, most recently from 1e9e62a to 1112799 Compare January 12, 2024 12:42
@thomas-senechal thomas-senechal force-pushed the 1301-use-wails-for-front-end branch 5 times, most recently from 41cb264 to 7b18a9a Compare January 15, 2024 15:54
@thomas-senechal thomas-senechal force-pushed the 1301-use-wails-for-front-end branch from fc08020 to 85c4fe7 Compare January 15, 2024 16:25
@thomas-senechal
Copy link
Member Author

Current state:

  • MacOS is working fine following some discussions with Wails dev and PRs sent to Wails.
  • Windows, there are still a few bugs on Windows that need to be fixed such as a crash when right clicking the systray and a Window not appearing. We have some fixes that will be fixed with PRs to be send to Wails repo.
  • Linux, extremely unstable. It looks like the Linux implementation lacks of event handling at the moment. Which means that we can't modify the systray right and left click behaviors. We can't reopen an hidden Window due to this lack of event (event not triggered -> callback that handles hide instead of close never called). I tried to add event handling but I couldn't do it in a few hours due to a lack of knowledge on GTK.

In conclusion, Wails v3 will be a great product once ready. But for now, the alpha versions lacks of features and are still too unstable for MS, even for an alpha release. We might come back to Wails for MS once it is more stable

So, Moving MS to Wails is in standby and this issue will be closed.

@thomas-senechal
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Wails for Front End
1 participant