Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change here can silently break tests in station #920

Open
Thykof opened this issue Apr 23, 2024 · 0 comments
Open

Change here can silently break tests in station #920

Thykof opened this issue Apr 23, 2024 · 0 comments
Labels

Comments

@Thykof
Copy link
Contributor

Thykof commented Apr 23, 2024

The end2end test of the wallet or mainly in the station repo.

The tests there are call to execute function that call the wallet to sign. So when we release a new version of the wallet, the test on station side can break without warning.

So we are testing the endpoint of the wallet through station.

I think we should test the endpoint of the wallet in the wallet repository, so that any change that break the e2e tests will make the CI fail and prevent from merging in the wallet.

@Thykof Thykof added the tech label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant