Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No logs on crash #910

Open
thomas-senechal opened this issue Apr 12, 2024 · 4 comments
Open

No logs on crash #910

thomas-senechal opened this issue Apr 12, 2024 · 4 comments

Comments

@thomas-senechal
Copy link
Member

Describe the bug
Sometimes, the wallet crashes but there are no logs about the crash in the log file. The only way to get the wallet logs is to run Massa Station from a terminal, which is not a good thing as most users do not know how to use a terminal, and so, this can be really painful for them.

To Reproduce

We don't know how to reproduce as we don't have any logs

Expected behavior
If a crash occures, the log file must have the information about the crash.

MassaStation version
v0.6.2

Desktop:

  • OS: ALL

Additional context

  • As there are litteraly no logs from the run, most of the time, the crashes seem to happen before the first log Serving massa wallet at ...
@thomas-senechal
Copy link
Member Author

From one of our users:
image
message.txt

@thomas-senechal
Copy link
Member Author

It looks like the failure comes from the plugin not being able to register due to a 404 error, which has an invalid body. The invalid character '<' looking for beginning of value error looks like some HTML has been received.
I don't think the issue is coming from inside the registry endpoint, as the only time we return 404 is when the plugin is not found, and we return an object: https://github.com/massalabs/station/blob/10c1fe27f8259084b65d80963974ad37cf2f5610/int/api/myplugin/register.go#L24C1-L28C1

Ensuring we log this error and make the plugin stop correctly should help us debug the issue in the future.

@Thykof
Copy link
Contributor

Thykof commented Apr 16, 2024

great investigation @thomas-senechal !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants