Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Wails Always on Top #704

Closed
wants to merge 1 commit into from
Closed

Conversation

pivilartisant
Copy link
Contributor

@pivilartisant pivilartisant commented Sep 12, 2023

before : wails popup behaves like normal window
after : wails popup will be always on top, user can minimize the window but it will not stack under if the user changes focus

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (6e444bd) 39.39% compared to head (24c263b) 39.39%.
Report is 4 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #704   +/-   ##
=======================================
  Coverage   39.39%   39.39%           
=======================================
  Files          20       20           
  Lines        1480     1480           
=======================================
  Hits          583      583           
  Misses        831      831           
  Partials       66       66           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pivilartisant
Copy link
Contributor Author

Since it's part of a TBD milestone we might not need to merge right now

@pivilartisant pivilartisant force-pushed the wail-popup-on-the-frontground branch from 24c263b to ce5d7d0 Compare September 12, 2023 14:13
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Thykof
Copy link
Contributor

Thykof commented Sep 12, 2023

@pivilartisant could you describe before/after behavior in the PR description?

@thomas-senechal
Copy link
Member

Did you had the bug mentionned in the issue ?
Did you discussed with someone about using the AlwaysOnTop option as the solution ?

In my opinion, it's a bit overkill because, if I'm not wrong, that means that the window can't be "minimized" or behind another one, which can be annoying especially on small screens

@pivilartisant
Copy link
Contributor Author

pivilartisant commented Sep 12, 2023

Did you had the bug mentionned in the issue ? Did you discussed with someone about using the AlwaysOnTop option as the solution ?

In my opinion, it's a bit overkill because, if I'm not wrong, that means that the window can't be "minimized" or behind another one, which can be annoying especially on small screens

No I did not have the bug mentioned in the issue unfortunately but there have been instances where I need to sign an operation and loose focus of the window making the popup slide under other applications. I do not know which is best from a UX perspective.

Window can be minimized which is positive, but indeed it will always be on top during any other interaction

@Thykof
Copy link
Contributor

Thykof commented Sep 12, 2023

I tested on macos, I prefer with option always on top false: when true, the wails popup is always on top of any other windows, and when it opens, it doesn't switch to show me the popup (I have to find it in the dock); when false it switch to the popup (more user friendly)

@pivilartisant
Copy link
Contributor Author

We chose to not go forward with this pr as it did not improve UX

@Thykof Thykof deleted the wail-popup-on-the-frontground branch September 13, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show wail popup on the frontground of all other windows
5 participants