-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Wails Always on Top #704
Conversation
Codecov ReportPatch and project coverage have no change.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #704 +/- ##
=======================================
Coverage 39.39% 39.39%
=======================================
Files 20 20
Lines 1480 1480
=======================================
Hits 583 583
Misses 831 831
Partials 66 66 ☔ View full report in Codecov by Sentry. |
Since it's part of a TBD milestone we might not need to merge right now |
24c263b
to
ce5d7d0
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@pivilartisant could you describe before/after behavior in the PR description? |
Did you had the bug mentionned in the issue ? In my opinion, it's a bit overkill because, if I'm not wrong, that means that the window can't be "minimized" or behind another one, which can be annoying especially on small screens |
No I did not have the bug mentioned in the issue unfortunately but there have been instances where I need to sign an operation and loose focus of the window making the popup slide under other applications. I do not know which is best from a UX perspective. Window can be minimized which is positive, but indeed it will always be on top during any other interaction |
I tested on macos, I prefer with option always on top false: when true, the wails popup is always on top of any other windows, and when it opens, it doesn't switch to show me the popup (I have to find it in the dock); when false it switch to the popup (more user friendly) |
We chose to not go forward with this pr as it did not improve UX |
before : wails popup behaves like normal window
after : wails popup will be always on top, user can minimize the window but it will not stack under if the user changes focus